Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Sep 14, 2022

Which issue does this PR close?

N/A

Rationale for this change

@iajoiner added downcast_value! in #3347 which is awesome 👏 . @andygrove suggested I use downcast_value! in #3454 (comment) which was also a great idea.

I noticed I had to add a use statement however:

use std::any::type_name;

I figured it would clean up the code and future uses of downcast_value! if users didn't have to manually add a use as well

What changes are included in this PR?

  1. add use std::any::type_name; to the macro definition
  2. remove now redundant use std::any::type_name; around the codebase

Are there any user-facing changes?

No

@alamb alamb marked this pull request as ready for review September 14, 2022 18:50
@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Sep 14, 2022
@iajoiner
Copy link
Contributor

@alamb Thanks! There is also a bug that can be fixed either now or in my next PR. The T in the macro need to be $T.

@alamb
Copy link
Contributor Author

alamb commented Sep 14, 2022

@alamb Thanks! There is also a bug that can be fixed either now or in my next PR.

I'll make a PR for it

@alamb
Copy link
Contributor Author

alamb commented Sep 14, 2022

PR for bug fix: #3486

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍 Only the PR title should be downcast_value rather than downcast_any 😃

@alamb alamb changed the title [MINOR] Change downcast_any! macro so it does not need to use use std::any::type_name; [MINOR] Change downcast_value! macro so it does not need to use use std::any::type_name; Sep 16, 2022
@alamb alamb merged commit 12f047e into apache:master Sep 17, 2022
@ursabot
Copy link

ursabot commented Sep 17, 2022

Benchmark runs are scheduled for baseline = b106b02 and contender = 12f047e. 12f047e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/clean_up_downcast_array branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants