Skip to content

test(physical-expr): clean up CASE linear lookup tests, remove unnecessary trait impls - #27567

Open
mzabaluev wants to merge 2 commits into
apache:mainfrom
mzabaluev:case-lookup-small-linear-scan-cleanup
Open

mzabaluev wants to merge 2 commits into
apache:mainfrom
mzabaluev:case-lookup-small-linear-scan-cleanup

Conversation

@mzabaluev

Copy link
Copy Markdown
Contributor

Cleanups after #26609:

mzabaluev and others added 2 commits November 18, 2026 21:13
The nulls in the linear lookup tests had zero values under them, which
match none of the literals, so the tests passed with the validity of
the input ignored. Put values matching a literal under the nulls, and
in the sliced Int64 test have nulls in the final partial validity word
as well as in full words.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In the implementation of optimized evaluation methods for CASE,
remove unnecessary `Hash`, `PartialEq`, and `Eq` impls for
`LiteralLookupTable` and `EvalMethod`. In a test that used `assert_eq!`,
use `assert_matches!` instead.
@github-actions github-actions Bot added the physical-expr Changes to the physical-expr crates label Nov 18, 2026
@mzabaluev mzabaluev changed the title test: clean up CASE linear lookup tests, remove unnecessary trait impls test(physical-expr): clean up CASE linear lookup tests, remove unnecessary trait impls Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant