Repository navigation
Docs: document manual catalog impls and how compilation got faster - #24362
Merged
Merged
Conversation
github-actions
Bot
added
core
alamb
changed the title
alamb
marked this pull request as ready for review
August 14, 2026 11:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24362 +/- ##
==========================================
- Coverage 81.17% 81.17% -0.01%
==========================================
Files 1109 1109
Lines 388117 388164 +47
Branches 388117 388164 +47
==========================================
+ Hits 315071 315108 +37
- Misses 54504 54509 +5
- Partials 18542 18547 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks for the quick review @Dandandan |
imtherealnaska
pushed a commit
to imtherealnaska/datafusion
that referenced
this pull request
Aug 16, 2026
…pache#24362) ## Which issue does this PR close? - Follow on to apache#24325 - Follow on to apache#24326 - Follow on to apache#24329 - Follow on to apache#24330 ## Rationale for this change @Dandandan came up with a very clever way to improve compile time, see apache#13814 (comment) However, the workaround (to make a special future and implement the async trait manually) is not obvious (at least to me) and I worry it might get removed in the future by accident, as we don't have any checks to prevent the regression Thus I think some comments explaining the pattern and how it would work will help avoid such a problem ## What changes are included in this PR? Add comments explaining why the code is done this way ## Are these changes tested? Comments only ## Are there any user-facing changes? No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-catalogcompile time ~6x #24325datafusion-sessioncompile time ~1.7x #24326datafusioncore compile time ~10x #24329datafusion-catalog-listingcompile time ~4.4x #24330Rationale for this change
@Dandandan came up with a very clever way to improve compile time, see #13814 (comment)
However, the workaround (to make a special future and implement the async trait manually) is not obvious (at least to me) and I worry it might get removed in the future by accident, as we don't have any checks to prevent the regression
Thus I think some comments explaining the pattern and how it would work will help avoid such a problem
What changes are included in this PR?
Add comments explaining why the code is done this way
Are these changes tested?
Comments only
Are there any user-facing changes?
No