Skip to content

change: fully deprecated the acceptance of value field in VirtualTables - #24346

Open
eliot1480 wants to merge 1 commit into
apache:mainfrom
eliot1480:change-virtualtable-consumer-to-only-accept-expressions
Open

change: fully deprecated the acceptance of value field in VirtualTables#24346
eliot1480 wants to merge 1 commit into
apache:mainfrom
eliot1480:change-virtualtable-consumer-to-only-accept-expressions

Conversation

@eliot1480

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

#23608

Rationale for this change

This PR is the final step in fully deprecating the VirtualTables.values, as we now only allow the consumption of expressions instead of the value field as well.

What changes are included in this PR?

These changes remove the deprecated VirtualTable.values consumer path, including the old literal-row conversion helper and the broad deprecation allowance around from_read_rel. The consumer now handles empty virtual tables, one-row empty relations, and normal virtual table rows using VirtualTable.expressions only.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the substrait Changes to the substrait crate label Aug 13, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.18%. Comparing base (f171587) to head (a03ba1f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ubstrait/src/logical_plan/consumer/rel/read_rel.rs 78.12% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24346   +/-   ##
=======================================
  Coverage   81.17%   81.18%           
=======================================
  Files        1109     1109           
  Lines      388033   387995   -38     
  Branches   388033   387995   -38     
=======================================
- Hits       314985   314975   -10     
+ Misses      54509    54478   -31     
- Partials    18539    18542    +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove usages of deprecated VirtualTable.values field

2 participants