change: fully deprecated the acceptance of value field in VirtualTables - #24346
Open
eliot1480 wants to merge 1 commit into
Open
change: fully deprecated the acceptance of value field in VirtualTables#24346eliot1480 wants to merge 1 commit into
eliot1480 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24346 +/- ##
=======================================
Coverage 81.17% 81.18%
=======================================
Files 1109 1109
Lines 388033 387995 -38
Branches 388033 387995 -38
=======================================
- Hits 314985 314975 -10
+ Misses 54509 54478 -31
- Partials 18539 18542 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#23608
Rationale for this change
This PR is the final step in fully deprecating the
VirtualTables.values, as we now only allow the consumption of expressions instead of the value field as well.What changes are included in this PR?
These changes remove the deprecated
VirtualTable.valuesconsumer path, including the old literal-row conversion helper and the broad deprecation allowance aroundfrom_read_rel. The consumer now handles empty virtual tables, one-row empty relations, and normal virtual table rows usingVirtualTable.expressionsonly.Are these changes tested?
Yes.
Are there any user-facing changes?
No.