Support Date32/Date64 in unwrap_cast optimization#21665
Open
Dandandan wants to merge 2 commits intoapache:mainfrom
Open
Support Date32/Date64 in unwrap_cast optimization#21665Dandandan wants to merge 2 commits intoapache:mainfrom
Dandandan wants to merge 2 commits intoapache:mainfrom
Conversation
github-actions
bot
added
logical-expr
Contributor
Author
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unwrap-cast-date-types (e9a740e) to 8dedd12 (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unwrap-cast-date-types (e9a740e) to 8dedd12 (merge-base) diff using: tpcds File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unwrap-cast-date-types (e9a740e) to 8dedd12 (merge-base) diff using: tpch File an issue against this benchmark runner |
Dandandan
force-pushed
the
unwrap-cast-date-types
branch
2 times, most recently
from
f2d022e to
4d0268f
Compare
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
Add Date32 and Date64 to the supported numeric types in the existing
unwrap_cast_in_comparison optimizer. This allows filters like
CAST(CAST(col AS Int32) AS Date32) >= Date32("2013-07-01")
to be simplified to
col >= UInt16(15887)
eliminating per-row CAST operations. Date32 is internally i32 (days
since epoch) and Date64 is i64 (ms since epoch), so they participate
in numeric comparisons the same way as their integer counterparts.
This affects ClickBench Q36-Q42, which all filter on EventDate
(stored as UInt16, viewed as Date32). Each query previously evaluated
4 CAST operations per row; now it does 0.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dandandan
force-pushed
the
unwrap-cast-date-types
branch
from
4d0268f to
df0953c
Compare
Contributor
Author
|
run benchmark clickbench_partitioned |
Contributor
Author
|
run benchmarks tpcds tpch |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unwrap-cast-date-types (df0953c) to 5c653be (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unwrap-cast-date-types (df0953c) to 5c653be (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unwrap-cast-date-types (df0953c) to 5c653be (merge-base) diff using: tpcds File an issue against this benchmark runner |
Contributor
Author
|
run benchmarks clickbench_partitioned |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unwrap-cast-date-types (df0953c) to 5c653be (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
15 tasks
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
martin-g
reviewed
Apr 16, 2026
| | DataType::Decimal32(_, _) | ||
| | DataType::Decimal64(_, _) | ||
| | DataType::Decimal128(_, _) | ||
| | DataType::Timestamp(_, _) |
Member
There was a problem hiding this comment.
It is a different use case but similar to the current one: Is something similar needed also for other temporal types missing here (like Duration and Interval for example) ?
|
|
||
| // Date↔Timestamp casts are lossy (drop time-of-day or add midnight), | ||
| // so unwrapping would change comparison semantics. | ||
| if (is_date_type(&lit_data_type) && target_type.is_temporal()) |
Member
There was a problem hiding this comment.
The comment is about Data<->Timestamp casts but this includes other temporal types like Duration and Interval. Maybe the comment should be extended.
But this also would prevent casting from Date32 to Date64. I think this might be desirable by someone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Filters like
WHERE EventDate >= '2013-07-01'on aUInt16column exposed asDate32via a view produceCAST(CAST(EventDate AS Int32) AS Date32) >= Date32("2013-07-01")— 4 CAST operations per row. The existingunwrap_cast_in_comparisonoptimizer can eliminate these but didn't supportDate32/Date64.What changes are included in this PR?
Add
Date32/Date64tois_supported_numeric_typeand the match arms intry_cast_numeric_literal. They are treated likeInt32/Int64since that's their physical representation (days / ms since epoch).A guard prevents Date↔Timestamp unwrapping, which is lossy (drops time-of-day).
ClickBench Q36-Q42 before:
After:
Are these changes tested?
Existing
caststests pass. ClickBench sqllogictest expectations updated.Are there any user-facing changes?
No.