Skip to content

Improve docs for Exprs and scalar functions #16036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 12, 2025

Which issue does this PR close?

Rationale for this change

While preparing to review #15911 from @timsaucer I was reviewing the current ScalarUDF situation and noticed some small doc improvements that could be made

What changes are included in this PR?

Improve some documentation about scalar functions, and others. Cosmetic changes only

Are these changes tested?

By docs CI

Are there any user-facing changes?

Just docs, no code changes

@alamb alamb added the documentation Improvements or additions to documentation label May 12, 2025
@github-actions github-actions bot added logical-expr Logical plan and expressions and removed documentation Improvements or additions to documentation labels May 12, 2025
@alamb
Copy link
Contributor Author

alamb commented May 12, 2025

The performance optimizations here are quite clever. Nice engineering work!

I am not sure what performance optimizations you are referring to I think this PR is just docs

Edit: I see it is spam / bot

@alamb alamb marked this pull request as draft May 13, 2025 13:29
@alamb alamb added the documentation Improvements or additions to documentation label May 13, 2025
@alamb alamb marked this pull request as ready for review May 13, 2025 13:40
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label May 13, 2025
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alamb

@alamb alamb merged commit 4efbeee into apache:main May 14, 2025
27 checks passed
@alamb
Copy link
Contributor Author

alamb commented May 14, 2025

Thanks again @timsaucer and @xudong963

jfahne pushed a commit to jfahne/datafusion that referenced this pull request May 18, 2025
* Improve docs for Exprs and scalar functions

* fix links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants