Minor: cleanup datafusion-spark scalar functions #15921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the scalar function testing macros in the DataFusion Spark module by cleaning up the handling of argument fields.
- Explicitly types the owned argument fields for clarity.
- Refactors the construction and passing of argument field references in the function invocation calls.
| @@ -28,7 +28,7 @@ pub mod test { | |||
| let expected: datafusion_common::Result<Option<$EXPECTED_TYPE>> = $EXPECTED; | |||
| let func = $FUNC; | |||
|
|
|||
| let arg_fields_owned = $ARGS | |||
| let arg_fields_owned: Vec<arrow::datatypes::Field> = $ARGS | |||
There was a problem hiding this comment.
[nitpick] If $ARGS already yields a Vecarrow::datatypes::Field, the explicit type annotation might be redundant. Consider removing it or adding a comment to clarify its purpose.
Suggested change
| let arg_fields_owned: Vec<arrow::datatypes::Field> = $ARGS | |
| let arg_fields_owned = $ARGS |
Copilot uses AI. Check for mistakes.
|
Thank you for the review @blaginin |
alamb
commented
May 2, 2025
| args: $ARGS, | ||
| number_rows: cardinality, | ||
| return_field: &return_field, | ||
| arg_fields: arg_fields.clone(), |
There was a problem hiding this comment.
in particular the change is to avoid calling collect twice and instead create the vec once and reuse it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I was reviewing the macro added in #15917 and thought I could make it slightly simpler
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?