fix: correctly specify the nullability of map_values return type
#15901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The broken tests are failing on main as well: |
alamb
approved these changes
Apr 30, 2025
|
I merged this PR up from main to get the fix for CI failures |
|
Thanks, there is another failure in CI which is unrelated |
I re-started the failed CI check |
|
Thanks again @rluvaton |
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
…pache#15901) Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
but related to:
return_typein favor ofreturn_type_from_args#15662Rationale for this change
The map_values UDF does not specify correctly the nullability of the result list.
when the input map array is nullable the output list is nullable, when the input map array values is nullable, the output list items are nullable
What changes are included in this PR?
updated
map_valuesto usereturn_type_from_argsAre these changes tested?
yes
Are there any user-facing changes?
yes