Fix flatten scalar function when inner list is FixedSizeList
#15898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alamb
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Thank you for the quick action @gstvg -- this looks good to me and the Ci has all passed.
Also thank you @berkaysynnada and @joroKr21 for the quick action
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
After #15149,
flattenstopped working forList(FixedSizeList)because it expected the inner fixed size list to be casted to list, which wasn't happening anymore.Looking back, #15160 correctly stopped using ArrayFunctionSignature::RecursiveArray, which I expected would make only the top level list be coerced, and it would break, but it didn't. It appears that recursive lists continued to be coerced
And then #15149 refactored that code path with the correct behavior, exposing the issue in
flattenWhat changes are included in this PR?
If the inner value is a fixed size list, it get's coerced to list
Are these changes tested?
Currently broken tests now pass
Are there any user-facing changes?
Broken path now works