feat: Add tracing regression tests #15673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffreyclaude
force-pushed
the
feat/tracing_tests
branch
2 times, most recently
from
113ead7 to
d3a171b
Compare
geoffreyclaude
force-pushed
the
feat/tracing_tests
branch
2 times, most recently
from
c5da1f8 to
aa7bb2e
Compare
geoffreyclaude
force-pushed
the
feat/tracing_tests
branch
from
aa7bb2e to
4dc5ce2
Compare
alamb
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
THis is great -- thank you @geoffreyclaude and @gabotechs ❤️
nirnayroy
pushed a commit
to nirnayroy/datafusion
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR adds smoke tests to verify that the
JoinSetTraceris correctly injected into DataFusion. These tests ensure that any changes to the core task spawning mechanism—which might break the tracing functionality—are caught early.What changes are included in this PR?
Are these changes tested?
Yes. The new tests run automatically in CI and serve as a regression check for the task spawning and tracing mechanism in DataFusion.
Are there any user-facing changes?
No, these changes only affect internal testing and do not introduce any user-facing modifications.