Minor: use FileScanConfig builder API in some tests #14938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
force-pushed
the
alamb/try_no_statistics
branch
from
ddc14bf to
40fcbe1
Compare
github-actions
bot
removed
core
alamb
commented
Feb 28, 2025
| file_source: source, | ||
| }; | ||
| let file_source = ParquetSource::default().with_statistics(statistics.clone()); | ||
| let scan_config = FileScanConfig::new( |
There was a problem hiding this comment.
I think this also makes the non-default fields more clear
berkaysynnada
approved these changes
Mar 1, 2025
|
Thank you for the review @berkaysynnada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I noticed some additional cleanup that was possible while reviewing #14685
The FileScanConfig builder API is both more concise but also requires fewer changes when / if FileScanConfig is changed
What changes are included in this PR?
Change some proto tests to use the more concise API
Are these changes tested?
Yes, by CI
Are there any user-facing changes?
No, this is entirely test code