Skip to content

Conversation

@sidshehria
Copy link

@sidshehria sidshehria commented Feb 19, 2025

close #14709

all the UDFs migrated to invoke_with_args. This issue would focus on the function in the datafusion/functions/src/unicode.

kindly check and merge

@github-actions github-actions bot added the functions Changes to functions implementation label Feb 19, 2025
@niebayes
Copy link
Contributor

Hi @sidshehria
After reviewing your code multiple times, it seems you're relatively new to Rust and the DataFusion community. I recommend taking some time to familiarize yourself with the Rust language and its tools to ensure your code is compilable. Once you're comfortable with the language, you'll be in a better position to complete this pull request.

@goldmedal goldmedal changed the title 14709 : migrated all the UDFS to invoke_with_args chore : migrated all the UDFS to invoke_with_args Feb 20, 2025
@alamb alamb marked this pull request as draft February 20, 2025 13:01
@alamb
Copy link
Contributor

alamb commented Feb 20, 2025

Thanks @sidshehria and @niebayes

Marking this one as a draft as we work through the comments

@github-actions
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Apr 22, 2025
@github-actions github-actions bot closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation Stale PR has not had any activity for some time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Unicode function to invoke_with_args

3 participants