Move All Physical Optimizer Tests to core/tests and Remove functions-aggregate Dependency #14298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Awesome -- thank you so much @berkaysynnada
As this is just moving code around (not changing behavior) I will merge this now to avoid it accumulating conflicts
| @@ -1593,7 +1593,6 @@ dependencies = [ | |||
| "datafusion-execution", | |||
| "datafusion-expr", | |||
| "datafusion-expr-common", | |||
| "datafusion-functions-aggregate", | |||
| mod limited_distinct_aggregation; | ||
| mod replace_with_order_preserving_variants; | ||
| mod sanity_checker; | ||
|
|
| @@ -41,7 +41,6 @@ datafusion-common = { workspace = true, default-features = true } | |||
| datafusion-execution = { workspace = true } | |||
| datafusion-expr = { workspace = true } | |||
| datafusion-expr-common = { workspace = true, default-features = true } | |||
| datafusion-functions-aggregate = { workspace = true } | |||
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Rather than keeping physical optimizer tests separate—which may lead to the duplication of utils and tests—we prefer consolidating them into a single file. This file should reside in the core module, as many optimizer tests depend on core tools. These changes also remove the functions-aggregate dependency on the physical-optimizer crate, which was previously required only for tests.
What changes are included in this PR?
just test migration
Are these changes tested?
Are there any user-facing changes?