Split the GroupColumn Implementations into smaller modules #13352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alamb Can you please take a look at this PR? Thanks! |
jonathanc-n
approved these changes
Nov 11, 2024
alamb
approved these changes
Nov 13, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
This looks great -- thank you @jiashenC and @jonathanc-n
alamb
changed the title
Contributor
Thank you very much for this PR -- I am sorry for the delay in reviewing (I was away for a few days). |
alamb
approved these changes
Nov 13, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @jiashenC and @jonathanc-n -- this looks great to me
alamb
pushed a commit
to alamb/datafusion
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13262.
What changes are included in this PR?
column.rs.group_column.rstoprimitive.rs,bytes.rs, andbytes_view.rs.Are these changes tested?
Using original tests.
Are there any user-facing changes?
No