-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Improve the coverage of bit_length
testing
#13336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e22a685
to
5af0ede
Compare
The CI fail doesn't relate to this PR. It could be fix by #13340 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you! @goldmedal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @goldmedal
@@ -64,6 +64,22 @@ _ (empty) false false false false | |||
NULL NULL NULL NULL NULL NULL | |||
NULL NULL NULL NULL NULL NULL | |||
|
|||
# TODO: move it back to `string_query.slt.part` after fixing the issue | |||
# see issue https://github.com/apache/datafusion/pull/13221 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13221 is now fixed, so I think we can move this test to string_query.slt
that being said, this seems like it is an improvement to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, it's my mistake. It should wait for #13329 actually. I pasted the wrong issue here 😢 . Thanks for reminding it.
Thanks @alamb and @austin362667 for reviewing |
Which issue does this PR close?
The follow-up PR of #13221
Rationale for this change
What changes are included in this PR?
String
,LargeString
, andDictionaryString
Are these changes tested?
yes
Are there any user-facing changes?
no