Improve the coverage of bit_length testing
#13336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldmedal
force-pushed
the
chore/13221-improve-test
branch
from
e22a685 to
5af0ede
Compare
|
The CI fail doesn't relate to this PR. It could be fix by #13340 |
austin362667
approved these changes
Nov 11, 2024
alamb
approved these changes
Nov 13, 2024
| @@ -64,6 +64,22 @@ _ (empty) false false false false | |||
| NULL NULL NULL NULL NULL NULL | |||
| NULL NULL NULL NULL NULL NULL | |||
|
|
|||
| # TODO: move it back to `string_query.slt.part` after fixing the issue | |||
| # see issue https://github.com/apache/datafusion/pull/13221 | |||
There was a problem hiding this comment.
#13221 is now fixed, so I think we can move this test to string_query.slt
that being said, this seems like it is an improvement to me
There was a problem hiding this comment.
oops, it's my mistake. It should wait for #13329 actually. I pasted the wrong issue here 😢 . Thanks for reminding it.
|
Thanks @alamb and @austin362667 for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
The follow-up PR of #13221
Rationale for this change
What changes are included in this PR?
String,LargeString, andDictionaryStringAre these changes tested?
yes
Are there any user-facing changes?
no