Skip to content

Improve the coverage of bit_length testing #13336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

goldmedal
Copy link
Contributor

Which issue does this PR close?

The follow-up PR of #13221

Rationale for this change

What changes are included in this PR?

  • Add tests for String, LargeString, and DictionaryString
  • Add the issue tracking link.

Are these changes tested?

yes

Are there any user-facing changes?

no

@goldmedal
Copy link
Contributor Author

The CI fail doesn't relate to this PR. It could be fix by #13340

Copy link
Contributor

@austin362667 austin362667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you! @goldmedal

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @goldmedal

@@ -64,6 +64,22 @@ _ (empty) false false false false
NULL NULL NULL NULL NULL NULL
NULL NULL NULL NULL NULL NULL

# TODO: move it back to `string_query.slt.part` after fixing the issue
# see issue https://github.com/apache/datafusion/pull/13221
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13221 is now fixed, so I think we can move this test to string_query.slt

that being said, this seems like it is an improvement to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, it's my mistake. It should wait for #13329 actually. I pasted the wrong issue here 😢 . Thanks for reminding it.

@goldmedal goldmedal merged commit a5d0563 into apache:main Nov 14, 2024
25 checks passed
@goldmedal goldmedal deleted the chore/13221-improve-test branch November 14, 2024 13:19
@goldmedal
Copy link
Contributor Author

Thanks @alamb and @austin362667 for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants