Skip to content

[logical-types branch] Backport native and logical types #13016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2024
Merged

[logical-types branch] Backport native and logical types #13016

merged 2 commits into from
Oct 21, 2024

Conversation

notfilippo
Copy link
Contributor

While #12853 is still in review I was wandering if I could make some additional progress on the logical-types branch.

@notfilippo notfilippo changed the title [logical-types branch] Backport native and logical types from #12853 [logical-types branch] Backport native and logical types Oct 19, 2024
@github-actions github-actions bot added the common Related to common crate label Oct 19, 2024
@notfilippo notfilippo mentioned this pull request Oct 21, 2024
Open
6 tasks
@jayzhan211
Copy link
Contributor

clippy error

@notfilippo
Copy link
Contributor Author

notfilippo commented Oct 21, 2024 •
edited
Loading

It seems unrelated.

@notfilippo
Copy link
Contributor Author

notfilippo commented Oct 21, 2024 •
edited
Loading

I'll open another PR to rebase the branch to main. Too many conflicts with main... Not sure how to proceed.

@notfilippo
Copy link
Contributor Author

For now I've just cherry-picked the fix commit. Hope that's enough

alamb
alamb approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this targets a feature branch it looks good to me -- let's keep it moving

@alamb alamb merged commit 861a8b7 into apache:logical-types Oct 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
common Related to common crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notfilippo @jayzhan211 @alamb @jonahgao