Skip to content

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Oct 15, 2024

Which issue does this PR close?

Closes #.
POC for checking #12944 , not for merged

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels Oct 15, 2024
@Rachelint
Copy link
Contributor Author

Rachelint commented Oct 16, 2024

I found it actually now a trivial change.
The challenge is that, we should refactor codes to support vectorize append firstly
(otherwise, we need to add a branch for row's appending, and as a reuslt, we remove a row level branch and add another...)

I am trying it.

@Rachelint
Copy link
Contributor Author

It is poc version of #12996

@Rachelint Rachelint closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants