Minor: Add `RuntimeEnvBuilder::build_arc() #12213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
alamb
commented
Aug 28, 2024
| .build() | ||
| .unwrap(), | ||
| ); | ||
| let runtime = RuntimeEnvBuilder::new() |
There was a problem hiding this comment.
this is a pretty good example of how the new API makes the code simpler
findepi
approved these changes
Aug 29, 2024
I am not aware of this being an established pattern (I think DataFusion uses Arc's a bit more than many Rust purists would prefer) |
|
I also have the same thought, maybe we don't really need Arc in some cases. We could gradually cleanup them later on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Small follow on to #12157 from @devanbenz
It is still somewhat awkward to make RuntimeEnv's, so let's make it slightly easier
What changes are included in this PR?
Adds a convenience method to
RuntimeEnvBuilderto build anArc<RuntimeEnv>Are these changes tested?
Yes, by CI
Are there any user-facing changes?
A new method