Skip to content

Conversation

dmitriibugakov
Copy link
Contributor

Which issue does this PR close?

Closes #11952.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) functions Changes to functions implementation labels Aug 15, 2024
@dmitriibugakov dmitriibugakov force-pushed the update-substr-utf8view branch from 58e8ff7 to 1ab2662 Compare August 15, 2024 19:36
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you @dmitrybugakov 🙏

I also filed #12031 to track an additional improvement of creating StringView as output of this function.

@alamb alamb merged commit 300a08c into apache:main Aug 16, 2024
24 checks passed
@dmitriibugakov dmitriibugakov deleted the update-substr-utf8view branch October 5, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes to functions implementation sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SUBSTR scalar function to support Utf8View
2 participants