Minor: Move MemoryCatalog*Provider into a module, improve comments #11183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 1, 2024
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! [`MemoryCatalogProvider`], [`MemoryCatalogProviderList`]: In-memory implementations of [`CatalogListProvider`] and [`CatalogProvider`]: |
There was a problem hiding this comment.
The point of the PR is to move the memory implementations into this module
|
Thank you for the review @jonahgao |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…pache#11183) * Minor: Move MemoryCatalog*Provider into a module, improve comments * fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #11182
Rationale for this change
There is a distinction between catalog API (the traits) and the provided simple implementations (e.g.
MemoryCatalogProvider*) that is not well reflected in the module structure now.If we make the code structure better mirror the distinction, it will both be clearer and set us up for future simplifications
What changes are included in this PR?
pub useAre these changes tested?
With existing CI
Are there any user-facing changes?
Better docs, no functional change