Remove dependency on physical-optimizer on functions-aggregates

[alamb]

          I would like to avoid this dependency if possible -- I will like to make a follow on PR to remove it -- similar to how I did in https://github.com/apache/datafusion/pull/14134

However when I just used the stub a few tests started failing on me

Originally posted by @alamb in #14190 (comment)

[alamb]

We are trying to make sure datafusion-physical-optimizers are not dependent on the actual function implementations so ensuring the crate doesn't have dependency will let the compiler ensure this

[berkaysynnada]

I've an idea. You're moving all tests to core/physical_optimizer with #14244. So, as of now, if we are writing tests core/physical_optimizer for physical optimizers, then datafusion/physical_optimizer/test_utils.rs can also be moved to core/physical_optimizer, and that will remove this dep. WDYT? If it sounds good, let's put all others (join_selection, limit-pushdown and more if there are) and test_utils into that PR.

[berkaysynnada]

I've an idea. You're moving all tests to core/physical_optimizer with #14244. So, as of now, if we are writing tests core/physical_optimizer for physical optimizers, then datafusion/physical_optimizer/test_utils.rs can also be moved to core/physical_optimizer, and that will remove this dep. WDYT? If it sounds good, let's put all others (join_selection, limit-pushdown and more if there are) and test_utils into that PR.

I can do that BTW if you are okay, and then work on https://github.com/apache/datafusion/pull/14235/files, and finally delete the core/physical_optimizer.

[alamb]

I've an idea. You're moving all tests to core/physical_optimizer with #14244. So, as of now, if we are writing tests core/physical_optimizer for physical optimizers, then datafusion/physical_optimizer/test_utils.rs can also be moved to core/physical_optimizer, and that will remove this dep. WDYT? If it sounds good, let's put all others (join_selection, limit-pushdown and more if there are) and test_utils into that PR.

Yes I think that sounds like a great idea. It would solve this issue too ❤

THANK YOU