Skip to content

Rename sqlparser_derive to sqlparser_procmacro, document features #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename sqlparser_derive to sqlparser_procmacro, document features #775

wants to merge 1 commit into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 28, 2022

Follow on from #765

rename crate to sqlparser_procmacro to be more consistent with other crates in the rust ecosystem

@alamb
Copy link
Contributor Author

alamb commented Dec 28, 2022

I plan to merge this once CI passes as I then plan to add CI tests for the other crate features

@alamb
Copy link
Contributor Author

alamb commented Dec 28, 2022

cc @tustvold

@alamb alamb mentioned this pull request Dec 28, 2022
Merged
@tustvold
Copy link
Contributor

_derive is more consistent with the ecosystem as whole for a derive macro?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3795008836

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.985%
Totals Coverage Status
Change from base Build 3794845435: 0.0%
Covered Lines: 13007
Relevant Lines: 15127
💛 - Coveralls

@alamb
Copy link
Contributor Author

alamb commented Dec 28, 2022

@tustvold notes prior art serde_derive, parquet_derive, etc -- will leave this alone

@alamb alamb closed this Dec 28, 2022
@alamb alamb deleted the alamb/derive_cleanup branch December 28, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @tustvold @coveralls