Minor: Error handling and minor fixes for ShuffleCodec #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccciudatu
commented
Nov 25, 2024
| // No need to redundantly serialize the child plan, as input plan(s) are recursively | ||
| // serialized by PhysicalPlanNode and will be available as `inputs` in `try_decode`. | ||
| // TODO: remove this field from the proto definition? | ||
| plan: None, |
There was a problem hiding this comment.
@austin362667 is this assessment legit or is there a reason that I missed for serialising the child plan as part of the ShuffleWriterExecNode proto instead of relying on the built-in recursive input plan serialisation?
As a side note, this change is needed so that we don't assume that the ShuffleCodec (i.e. self in the try_from_physical_plan(writer.plan.clone(), self) call) is the only extension codec needed for serialising the whole plan, but allow for additional extensions be registered without requiring this particular codec to be aware of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are required for allowing the ShuffleCodec to be used alongside other extension codecs, but this patch makes sense irrespective of supporting additional extensions:
unreachable!()with error results to allow adding fallback extension codecs for custom physical plans instead of panicking