Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add head, tail methods #915

Merged
merged 2 commits into from
Oct 21, 2024
Merged

feat: add head, tail methods #915

merged 2 commits into from
Oct 21, 2024

Conversation

ion-elgreco
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

Common methods similar to pyspark/polars/pandas api

What changes are included in this PR?

  • Adds a head method, which uses limit underneath. Same as tail but calls the count of the dataframe to know where to start returning it from

@ion-elgreco ion-elgreco changed the title feat: add head, tail methods feat: add head, tail methods Oct 13, 2024
timsaucer
timsaucer reviewed Oct 13, 2024
View reviewed changes
Copy link
Contributor

@timsaucer timsaucer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do have concerns about tail but head is great.

@ion-elgreco ion-elgreco mentioned this pull request Oct 13, 2024
Open
@ion-elgreco ion-elgreco requested a review from timsaucer October 13, 2024 15:03
@timsaucer timsaucer merged commit f59dd08 into apache:main Oct 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsaucer timsaucer timsaucer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ion-elgreco @timsaucer