Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose join_on #914

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat: expose join_on #914

merged 2 commits into from
Oct 15, 2024

Conversation

ion-elgreco
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

Was not yet exposed but very useful for inequality joins.

What changes are included in this PR?

  • Adds join_on method, which takes expressions

Are there any user-facing changes?

  • new method

timsaucer
timsaucer approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@timsaucer timsaucer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this addition.

@ion-elgreco ion-elgreco requested a review from timsaucer October 13, 2024 15:03
@timsaucer timsaucer merged commit b4b03fe into apache:main Oct 15, 2024
15 checks passed
@Michael-J-Ward Michael-J-Ward mentioned this pull request Oct 18, 2024
Closed
@drauschenbach drauschenbach mentioned this pull request Nov 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsaucer timsaucer Awaiting requested review from timsaucer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ion-elgreco @timsaucer