Skip to content

Conversation

@mesejo
Copy link
Contributor

@mesejo mesejo commented Aug 31, 2023

Which issue does this PR close?

Partially addresses #463.

Rationale for this change

It will be nice for UX to have the full set of functions provided by rust-datafusion

What changes are included in this PR?

The following scalar math functions were added:

  • acosh
  • asinh
  • atanh
  • cbrt
  • cosh
  • degrees
  • factorial
  • gcd
  • lcm
  • nanvl
  • pi
  • radians
  • sinh
  • tanh

Are there any user-facing changes?

Yes

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mesejo

@andygrove andygrove merged commit bc62aaf into apache:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants