Add use_fabric_endpoint parameter to MicrosoftAzure class#1357
Merged
timsaucer merged 1 commit intoapache:mainfrom Jan 30, 2026
Merged
Add use_fabric_endpoint parameter to MicrosoftAzure class#1357timsaucer merged 1 commit intoapache:mainfrom
timsaucer merged 1 commit intoapache:mainfrom
Conversation
This change adds support for the use_fabric_endpoint parameter to the MicrosoftAzure object store class, enabling connections to Microsoft Fabric OneLake storage. The parameter allows users to specify that they want to use Data Lake Storage Gen2 endpoints (dfs.fabric.microsoft.com) instead of the default Azure Blob Storage endpoints (blob.core.windows.net), which is required for OneLake/Fabric storage access. Implementation follows the same pattern as existing boolean parameters (use_emulator, allow_http) by: - Adding the parameter to the PyO3 signature macro - Adding it as Option<bool> to the function parameters - Conditionally calling with_use_fabric_endpoint() on the builder Fixes apache#1356 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
timsaucer
approved these changes
Jan 30, 2026
Member
timsaucer
left a comment
There was a problem hiding this comment.
Looks great, thanks for the PR. I'll wait until I see CI in the green before I merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
use_fabric_endpointparameter to theMicrosoftAzureobject store class, enabling connections to Microsoft Fabric OneLake storage.Fixes #1356
Problem
The Python
MicrosoftAzureclass was missing theuse_fabric_endpointparameter that exists in the underlying Rustobject_storecrate. This prevented users from connecting to Microsoft Fabric OneLake storage, which requires Data Lake Storage Gen2 endpoints instead of Azure Blob Storage endpoints.Current behavior: Defaults to
https://onelake.blob.core.windows.net/...Required behavior: Support
https://onelake.dfs.fabric.microsoft.com/...Changes
Added the
use_fabric_endpointparameter to theMicrosoftAzureclass insrc/store.rs:Option<bool>(line 92)with_use_fabric_endpoint()(lines 130-132)This implementation follows the exact same pattern as existing boolean parameters (
use_emulator,allow_http).Usage Example
Testing Note
Comprehensive end-to-end testing of this feature requires:
I have manually verified that:
use_fabric_endpoint=TrueThe code change is minimal and follows existing patterns exactly, making it low-risk for existing functionality.
Checklist