Skip to content

Conversation

coderfender
Copy link
Contributor

Which issue does this PR close?

Closes #2489

Rationale for this change

Support native cast since we dont have support in arrow / df

What changes are included in this PR?

Cast ops changes in cast.rs
Update logic on scala side to support decimal -> bool type
Reenable cast tests in CometCastSuite

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.41%. Comparing base (f09f8af) to head (d3aca76).
⚠️ Report is 554 commits behind head on main.

Files with missing lines Patch % Lines
...scala/org/apache/comet/expressions/CometCast.scala 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2490      +/-   ##
============================================
+ Coverage     56.12%   58.41%   +2.28%     
- Complexity      976     1436     +460     
============================================
  Files           119      146      +27     
  Lines         11743    13510    +1767     
  Branches       2251     2350      +99     
============================================
+ Hits           6591     7892    +1301     
- Misses         4012     4389     +377     
- Partials       1140     1229      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderfender coderfender force-pushed the impl_comet_native_decimal_bool_cast branch 2 times, most recently from ef7303d to d3aca76 Compare September 29, 2025 16:03
@coderfender coderfender changed the title feat:support_decimal_types_bool_cast_native_impl feat: support_decimal_types_bool_cast_native_impl Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support native decimal to boolean cast
5 participants