[WIP]feat: Implement array-to-string cast support #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
============================================
+ Coverage 56.12% 58.35% +2.23%
- Complexity 976 1436 +460
============================================
Files 119 146 +27
Lines 11743 13515 +1772
Branches 2251 2352 +101
============================================
+ Hits 6591 7887 +1296
- Misses 4012 4393 +381
- Partials 1140 1235 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cfmcgrady
force-pushed
the
cast-array-to-string
branch
from
15e8ee2 to
effb775
Compare
andygrove
reviewed
Sep 26, 2025
| } | ||
|
|
||
| test("cast ArrayType to StringType") { | ||
| sql("set spark.comet.explainFallback.enabled=true") |
There was a problem hiding this comment.
We tend to use withSQLConf to set configs in tests so that the config change is isolated to the specific test.
Suggested change
| sql("set spark.comet.explainFallback.enabled=true") | |
| withSQLConf(CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.key -> "true") { |
There was a problem hiding this comment.
Yep, I see, this is just for debugging GA failures.
cfmcgrady
force-pushed
the
cast-array-to-string
branch
from
d461986 to
2f160fc
Compare
cfmcgrady
force-pushed
the
cast-array-to-string
branch
from
2f160fc to
c104e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?