chore: enable map_values testing since we fall back on nested types for defa… #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or default values
zhuqi-lucas
force-pushed
the
enable_map_values_testing
branch
from
88d454c to
0e6fd39
Compare
zhuqi-lucas
changed the title
Contributor
Author
|
Thank you @mbutrovich for review, i just noticed some fix in apache datafusion is in progress. But it seems we already fall back to spark map functions, so i enable the test now. After we change to comet execution, we can also keep it to see if it's fixed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
============================================
- Coverage 56.12% 54.79% -1.34%
- Complexity 976 1002 +26
============================================
Files 119 129 +10
Lines 11743 12508 +765
Branches 2251 2350 +99
============================================
+ Hits 6591 6854 +263
- Misses 4012 4447 +435
- Partials 1140 1207 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@zhuqi-lucas The problem is not in map_values it is deeper problem with reader itself, I provided some investigation details in #1789 (comment) |
Contributor
Author
|
Thank you @comphead for explain! |
Contributor
|
Closing this PR in favor of #1835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ult values
Which issue does this PR close?
Part of
Closes #1789
We should fix map_values when we use native comet again.
Rationale for this change
Now we fall back to Spark for this query in #1799 , we can enable the map_values testing.
What changes are included in this PR?
Now we fall back to Spark for this query in #1799 , we can enable the map_values testing.
How are these changes tested?