-
Notifications
You must be signed in to change notification settings - Fork 205
chore: Bump arrow to 18.3.0 #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unfortunately Arrow Java requires Java 11 since version 18, so we cannot bump the version number as we have to support Java 8. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
============================================
+ Coverage 56.12% 59.45% +3.32%
- Complexity 976 1139 +163
============================================
Files 119 128 +9
Lines 11743 12523 +780
Branches 2251 2355 +104
============================================
+ Hits 6591 7445 +854
+ Misses 4012 3886 -126
- Partials 1140 1192 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks @Kontinuation. Let's talk about dropping support for Java 8? #1775 |
@Kontinuation We merged the PR to stop building with JDK 8 |
b865e0e
to
dd1deeb
Compare
I have rebased this branch onto the latest main. The ubuntu-latest/java 17-spark-4.0/java test slowed down then failed. I'm not sure if it is transient or not.
|
Yes, this is a transient issue and we have not figured out a root cause. It did start happening just after we changed the DataFusion dependency to be a git dependency on that latest code, soi that is one clue. We do not understand why this only happens on the Spark 4 builds. Here are the timings for the above test from the Spark 3.5 run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kontinuation
Which issue does this PR close?
Closes #1615 .
Rationale for this change
Issue #1615 is caused by a bug in arrow-java. The latest release 18.3.0 has shipped the fix for that bug so we can simply bump the version of arrow to fix the issue.
I have also found that apache/arrow-java#707 is also shipped with 18.3.0, it has fixed the sliced string array importing issue, so we can remove the workaround in our code.
What changes are included in this PR?
How are these changes tested?