Skip to content

chore: Reenable nested types for CometFuzzTestSuite with int96 #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 21, 2025

Conversation

mbutrovich
Copy link
Contributor

@mbutrovich mbutrovich commented May 20, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

apache/datafusion#16058 Fixed schema coercion for int96 within nested types. We should reenable CometFuzzTestSuite to exercise this code path.

What changes are included in this PR?

CometFuzzTestSuite's int96 test will now use nested types in the schema.

How are these changes tested?

CometFuzzTestSuite.

@mbutrovich mbutrovich marked this pull request as ready for review May 20, 2025 22:31
@mbutrovich
Copy link
Contributor Author

This should be ready for review now.

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending with CI

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@andygrove
Copy link
Member

Perhaps this PR should also remove this item from the compatibility guide?

- Reading legacy INT96 timestamps contained within complex types can produce different results to Spark

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.62%. Comparing base (f09f8af) to head (467e317).
Report is 202 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1761      +/-   ##
============================================
+ Coverage     56.12%   58.62%   +2.50%     
- Complexity      976     1140     +164     
============================================
  Files           119      130      +11     
  Lines         11743    12663     +920     
  Branches       2251     2362     +111     
============================================
+ Hits           6591     7424     +833     
- Misses         4012     4054      +42     
- Partials       1140     1185      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbutrovich
Copy link
Contributor Author

Perhaps this PR should also remove this item from the compatibility guide?

- Reading legacy INT96 timestamps contained within complex types can produce different results to Spark

Good catch, thank you!

@andygrove andygrove merged commit b24a6d4 into apache:main May 21, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants