-
Notifications
You must be signed in to change notification settings - Fork 205
chore: Reenable nested types for CometFuzzTestSuite with int96 #1761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should be ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending with CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Perhaps this PR should also remove this item from the compatibility guide?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1761 +/- ##
============================================
+ Coverage 56.12% 58.62% +2.50%
- Complexity 976 1140 +164
============================================
Files 119 130 +11
Lines 11743 12663 +920
Branches 2251 2362 +111
============================================
+ Hits 6591 7424 +833
- Misses 4012 4054 +42
- Partials 1140 1185 +45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Good catch, thank you! |
Which issue does this PR close?
Closes #.
Rationale for this change
apache/datafusion#16058 Fixed schema coercion for int96 within nested types. We should reenable CometFuzzTestSuite to exercise this code path.
What changes are included in this PR?
CometFuzzTestSuite's int96 test will now use nested types in the schema.
How are these changes tested?
CometFuzzTestSuite.