RAT-98: Updated tests for gitignore changes & deprecated options #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Claudenw did you accidentally push an old branch as the build fails with spotbugs errors? |
|
@ottlinger My next step is to see how I can split this into smaller pieces. |
This was referenced Jan 12, 2025
removed unused import
Removed commented out code
Claudenw
changed the title
ottlinger
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Due to the repo&branch mixup - LGTM.
Proposed changelog entry is:
<action issue="RAT-98" type="add" dev="claudenw">
Report skipped/excluded files and integrate testing of inclusion-exclusion and DocumentNames to work under Unix, Windows and Mac.
</action>
Pls go ahead @Claudenw & thanks for your work to keep track of these changes.
Added changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues raised by report skipped processing, specifically issues with Maven not correctly skipping files that should be skipped.
In the process of working on the bugs additional testing code was implemented to allows testing on file systems that are not native. Most name based code now checks against UNIX, WINDOWS, and OSX.
Significant additional work was undertaken to ensure that the document names work as expected.
This is the last PR in the set and enables the tests for the gitignore changes as well as replaces deprecated options in some tests.