This repository was archived by the owner on May 25, 2021. It is now read-only.
COUCHDB-769: Store attachments in the external storage. #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplementation, supports OpenStack Swift and SoftLayer Object store
| DiskLen = DiskLenTmp, | ||
| DigestProp = case base64:encode(Md5) of | ||
| <<>> -> []; | ||
| Digest -> [{<<"digest">>, <<"md5-", Digest/binary>>}] |
There was a problem hiding this comment.
Can we not repeat ourself in Digest generation?
|
Please fix style: 80 chars line length, commas/spaces, etc. |
|
@kxepal @rnewson
|
|
@kxepal Can you please review the recent code? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation that allows CouchDB to store attachments outside of the database file.
This implementation supports OpenStack Swift and SoftLayer Object store