Skip to content

Conversation

@GitToTheHub
Copy link
Contributor

@GitToTheHub GitToTheHub commented Oct 27, 2025

  • CordovaInterfaceImpl called the deprecated method CordovaPlugin.onRequestPermissionResult but not the new one CordovaPlugin.onRequestPermissionsResult. Now it will be called also.
  • Fixes onRequestPermissionResult deprecation issue #1388
  • Renamed CordovaInterfaceImpl.onRequestPermissionResult to CordovaInterfaceImpl.onRequestPermissionsResult to reflect the new method name

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- Fixes apache#1388
- `CordovaInterfaceImpl` called the deprecated method `CordovaPlugin.onRequestPermissionResult` but not the new one. Now the one will also be called.
- Renamed `CordovaInterfaceImpl.onRequestPermissionResult` to `CordovaInterfaceImpl.onRequestPermissionsResult` to reflect the new method name
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.79%. Comparing base (cab5c5b) to head (038ae4c).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1855       +/-   ##
===========================================
- Coverage   72.12%   60.79%   -11.33%     
===========================================
  Files          23       23               
  Lines        1844     4811     +2967     
===========================================
+ Hits         1330     2925     +1595     
- Misses        514     1886     +1372     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

onRequestPermissionResult deprecation issue

2 participants