Skip to content

[NET-736] Refactored testNET641 to use parameterized unit testing #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[NET-736] Refactored testNET641 to use parameterized unit testing #328

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f5b76
Refactored testNET641 to use parameterized unit testing
Monilnarang Feb 11, 2025
18e934a
used @FieldSource instead of @CsvSource
Monilnarang Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/test/java/org/apache/commons/net/util/SubnetUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,12 @@ public class SubnetUtilsTest {
ImmutablePair.of("192.168.0.1/32", 1L));
// @formatter:on

private static final List<ImmutablePair<String, String>> VALUE_SETS_NET641 = Arrays.asList(
ImmutablePair.of("192.168.1.0/00", "0.0.0.0"),
ImmutablePair.of("192.168.1.0/30", "0.0.0.0"),
ImmutablePair.of("192.168.1.0/31", "0.0.0.0"),
ImmutablePair.of("192.168.1.0/32", "0.0.0.0"));

@Test
public void testAddresses() {
final SubnetUtils utils = new SubnetUtils("192.168.0.1/29");
Expand Down Expand Up @@ -345,12 +351,12 @@ public void testNET624() {
assertThrows(IllegalArgumentException.class, () -> new SubnetUtils("0.0.0.0", "0.0.0.1"));
}

@Test
public void testNET641() {
assertFalse(new SubnetUtils("192.168.1.0/00").getInfo().isInRange("0.0.0.0"));
assertFalse(new SubnetUtils("192.168.1.0/30").getInfo().isInRange("0.0.0.0"));
assertFalse(new SubnetUtils("192.168.1.0/31").getInfo().isInRange("0.0.0.0"));
assertFalse(new SubnetUtils("192.168.1.0/32").getInfo().isInRange("0.0.0.0"));
@ParameterizedTest
@FieldSource("VALUE_SETS_NET641")
public void testNET641(final ImmutablePair<String, String> pair) {
final String cidrNotation = pair.getKey();
final String address = pair.getValue();
assertFalse(new SubnetUtils(cidrNotation).getInfo().isInRange(address));
}

@Test
Expand Down