Fix Listing backup schedules

[Pearl1594]

Description

This PR fixes the issue with listing backup schedules caused by #9451

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (046870e) to head (e63029b).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...api/command/user/backup/ListBackupScheduleCmd.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               main    #9749    +/-   ##
==========================================
  Coverage     15.78%   15.78%            
- Complexity    12551    12553     +2     
==========================================
  Files          5625     5625            
  Lines        491972   491972            
  Branches      63764    63917   +153     
==========================================
+ Hits          77662    77673    +11     
+ Misses       405850   405837    -13     
- Partials       8460     8462     +2     

Flag	Coverage Δ
uitests	4.03% <ø> (ø)
unittests	16.60% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

clgtm and logic seems fair. @weizhouapache @sureshanaparti can you review as well? @JoaoJandre this is a regression, so I think we should considder this a BLOCKER issue.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[JoaoJandre]

LGTM

[sureshanaparti]

clgtm

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11253

[DaanHoogland]

@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11587)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60358 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9749-t11587-kvm-ol8.zip
Smoke tests completed. 136 look OK, 0 have errors, 5 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
all_test_vpc_redundant	Skipped	---	test_vpc_redundant.py
all_test_vpc_router_nics	Skipped	---	test_vpc_router_nics.py
all_test_vpc_vpn	Skipped	---	test_vpc_vpn.py
all_test_webhook_delivery	Skipped	---	test_webhook_delivery.py
all_test_webhook_lifecycle	Skipped	---	test_webhook_lifecycle.py

[JoaoJandre]

@Pearl1594 could you describe what happened before this patch and what tests were made to validate that this patch fixes the issue?

[Pearl1594]

@JoaoJandre because of the incorrect check, it never listed any backup schedules even if there were present.

[JoaoJandre]

@JoaoJandre because of the incorrect check, it never listed any backup schedules even if there were present.

@Pearl1594 I see. So did you test that the solution fixes the issue completely? I ask because there are no tests on the PR description and nowhere else on the PR.

[Pearl1594]

Yes, unfortunately this class wasn't covered with tests, and I didn't add any either. But this has at this point been manually tested considering the release is on-going. Probably I could add tests in a subsequent enhancement PR that I have already opened for 4.20.1.

[JoaoJandre]

Yes, unfortunately this class wasn't covered with tests, and I didn't add any either. But this has at this point been manually tested considering the release is on-going. Probably I could add tests in a subsequent enhancement PR that I have already opened for 4.20.1.

@Pearl1594 What I meant in my previous messages is that the PR is missing the description of the steps that you made to verify that this PR fixes the described issue, something like this: #9662 (review)

[Pearl1594]

Ah, my bad. I didn't quite understand it.
Manual test done:

1. Created a Backup offering
2. Created a VM and associated it to a backup offering
3. Configured backup Schedule for the VM
4. After Creating the schedule, move to the Scheduled Backups tab in the pop-up window. You should now be able to see the schedule(s) created.
   
   (Which was, before this fix empty)