Skip to content

server: remove username required condition for listVmsForImport #9124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohityadavcloud merged 4 commits into from
Jun 14, 2024
Merged

server: remove username required condition for listVmsForImport #9124

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10fc4a4
server: remove username required condition for listVmsForImport
shwstppr May 24, 2024
c325034
fix
shwstppr May 24, 2024
24142e4
Merge branch '4.19' into fix-listvmforimport-usernameparam
shwstppr Jun 12, 2024
e2fb453
revert
shwstppr Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2446,11 +2446,7 @@ public ListResponse<UnmanagedInstanceResponse> listVmsForImport(ListVmsForImport
throw new InvalidParameterValueException("Please specify a valid zone.");
}
final String hypervisorType = cmd.getHypervisor();
if (Hypervisor.HypervisorType.KVM.toString().equalsIgnoreCase(hypervisorType)) {
if (StringUtils.isBlank(cmd.getUsername())) {
throw new InvalidParameterValueException("Username need to be provided.");
}
} else {
if (!Hypervisor.HypervisorType.KVM.toString().equalsIgnoreCase(hypervisorType)) {
throw new InvalidParameterValueException(String.format("VM Import is currently not supported for hypervisor: %s", hypervisorType));
}

Expand Down