UI: Keyboard label shortcut

[apurv-1]

Description

fixes #4798

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Dashboard.-.CloudStack.-.Google.Chrome.2021-08-31.18-07-03.mp4

[apurv-1]

Toggle show/hide keyboard short keys are working with "F", but the action for a specific keyboard event isn't working now.

[davidjumani]

@blueorangutan ui

[blueorangutan]

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-288)

[rohityadavcloud]

@blueorangutan ui

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5122 (SL-JID-295)

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[borisstoyanov]

@apurv-1 you can maybe sync with @utchoang on vue3 issues?

[apurv-1]

@apurv-1 you can maybe sync with @utchoang on vue3 issues?

sure, thanks @borisstoyanov

[DaanHoogland]

@apurv-1 can you look at the conflicts, please?

[DaanHoogland]

@davidjumani @borisstoyanov @apurv-1 moving this from milestone 4.18.0.0 to unplanned

[apurv-1]

@blueorangutan ui

[blueorangutan]

@apurv-1 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/5122 (QA-JID-81)

[codecov]

Codecov Report

Merging #5122 (b39cd0d) into main (62b332e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               main    #5122    +/-   ##
==========================================
  Coverage     12.69%   12.69%            
- Complexity     8664     8674    +10     
==========================================
  Files          2718     2729    +11     
  Lines        256362   256579   +217     
  Branches      39967    39987    +20     
==========================================
+ Hits          32538    32575    +37     
- Misses       219686   219859   +173     
- Partials       4138     4145     +7     

see 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[shwstppr]

@apurv-1 PR doesn't work as yet. Needs some more fixes. Testing changes

[shwstppr]

Converting this to draft for now as it needs changes to cleanup unused code and deduplicate short keys

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/5122 (QA-JID-86)

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[rohityadavcloud]

Thanks for the PR - given the issues around incompatibilities of the keyboard/shortcuts library with Vue3 and antd, this PR would have to be redone. We can explore this in future. Thanks to the GSoC student and all those involved.

[apurv-1]

@rohityadavcloud opened up #8250, it works with Vue3. Also, we can revamp the designs.

[DaanHoogland]

@rohityadavcloud opened up #8250, it works with Vue3. Also, we can revamp the designs.

@apurv-1 will you also port the other keys then 'r' to that new PR?

[apurv-1]

@DaanHoogland Yes, I have suggested one more thing on that PR.