Skip to content

[WIP] Add support to update secondary and primary storage URLs #13193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 3 commits into
base: main
Choose a base branch
from

address comments

bb8f28c
Select commit
Loading
Failed to load commit list.
Draft

[WIP] Add support to update secondary and primary storage URLs #13193

address comments
bb8f28c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 21, 2026 in 4m 0s

Quality Gate failed

Failed conditions
28.3% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 4263 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.apache.commons.lang3.StringUtils" for "isAnyBlank". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5LRhwdack08QRgE_P1&open=AZ5LRhwdack08QRgE_P1&pullRequest=13193

Check warning on line 1451 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 70 to 64, Complexity from 15 to 14, Nesting Level from 3 to 2, Number of Variables from 15 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5BdKQjc-PA8pjUL6Z1&open=AZ5BdKQjc-PA8pjUL6Z1&pullRequest=13193

Check warning on line 308 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "rbdPoolXml". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5HUpiIilR_hphlMp5e&open=AZ5HUpiIilR_hphlMp5e&pullRequest=13193

Check warning on line 783 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5HUpehilR_hphlMp5c&open=AZ5HUpehilR_hphlMp5c&pullRequest=13193

Check warning on line 3007 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 74 to 64, Complexity from 20 to 14, Nesting Level from 6 to 2, Number of Variables from 21 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5BdKKhc-PA8pjUL6Zu&open=AZ5BdKKhc-PA8pjUL6Zu&pullRequest=13193

Check warning on line 1286 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 76 to 64, Complexity from 16 to 14, Nesting Level from 5 to 2, Number of Variables from 23 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5HUpehilR_hphlMp5d&open=AZ5HUpehilR_hphlMp5d&pullRequest=13193

Check warning on line 1225 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 100 to 64, Complexity from 28 to 14, Nesting Level from 5 to 2, Number of Variables from 23 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5BdKKhc-PA8pjUL6Zv&open=AZ5BdKKhc-PA8pjUL6Zv&pullRequest=13193

Check warning on line 1733 in server/src/test/java/com/cloud/storage/StorageManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace these 3 tests with a single Parameterized one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5LRh1Iack08QRgE_P2&open=AZ5LRh1Iack08QRgE_P2&pullRequest=13193

Check warning on line 433 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 127 to 64, Complexity from 19 to 14, Nesting Level from 3 to 2, Number of Variables from 12 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5BdKQjc-PA8pjUL6Z0&open=AZ5BdKQjc-PA8pjUL6Z0&pullRequest=13193

Check warning on line 1097 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 66 to 64, Complexity from 16 to 14, Nesting Level from 3 to 2, Number of Variables from 13 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5BdKKhc-PA8pjUL6Zy&open=AZ5BdKKhc-PA8pjUL6Zy&pullRequest=13193

Check warning on line 1560 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 68 to 64, Complexity from 19 to 14, Nesting Level from 3 to 2, Number of Variables from 15 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5BdKQjc-PA8pjUL6Z2&open=AZ5BdKQjc-PA8pjUL6Z2&pullRequest=13193

Check warning on line 967 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 112 to 64, Complexity from 22 to 14, Nesting Level from 3 to 2, Number of Variables from 25 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5BdKKhc-PA8pjUL6Zw&open=AZ5BdKKhc-PA8pjUL6Zw&pullRequest=13193

Check warning on line 307 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "rbdPoolXml" local variable. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5HUpiIilR_hphlMp5f&open=AZ5HUpiIilR_hphlMp5f&pullRequest=13193

Check warning on line 1513 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 106 to 64, Complexity from 35 to 14, Nesting Level from 3 to 2, Number of Variables from 27 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5BdKKhc-PA8pjUL6Zx&open=AZ5BdKKhc-PA8pjUL6Zx&pullRequest=13193

Check failure on line 1320 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.apache.commons.lang3.StringUtils" for "isAnyBlank". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5LRhwdack08QRgE_P0&open=AZ5LRhwdack08QRgE_P0&pullRequest=13193

Check warning on line 1701 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 76 to 64, Complexity from 23 to 14, Nesting Level from 6 to 2, Number of Variables from 24 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5BdKQjc-PA8pjUL6Zz&open=AZ5BdKQjc-PA8pjUL6Zz&pullRequest=13193
View more details on SonarQubeCloud