-
Notifications
You must be signed in to change notification settings - Fork 1.3k
pre-commit: fix inconsistent license #12551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Abhishek Kumar <[email protected]>
ecaf80b to
7b79d3b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12551 +/- ##
============================================
+ Coverage 17.61% 17.87% +0.26%
- Complexity 15659 16069 +410
============================================
Files 5914 5935 +21
Lines 530807 532338 +1531
Branches 64856 65086 +230
============================================
+ Hits 93512 95181 +1669
+ Misses 426781 426510 -271
- Partials 10514 10647 +133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sudo87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Thank you @shwstppr for this pr. |
sureshanaparti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
|
pre-commit GHA passes, merging |
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me this looks good, but @jbampton made the auto license action workflow. Any comments on the extra white spaces?
The original has the extra spaces: https://github.com/apache/cloudstack/blob/main/LICENSE.header The existing codebase for example the Java files do have this style of license with the extra spaces |
Description
Fix inconsitent license
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?