Fix to create instances with smaller templates (< 1 GB) on PowerFlex/ScaleIO storage

[sureshanaparti]

Description

This PR allows create instances with smaller templates (< 1 GB) on PowerFlex/ScaleIO storage (it's regression after #9008).

Fixes #10981

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Deployed instance using the template (http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2) on PowerFlex storage.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (9688cbb) to head (5976ec0).
Report is 3 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java	50.00%	4 Missing ⚠️
...hypervisor/kvm/storage/StorPoolStorageAdaptor.java	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11211   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
  Complexity    13274    13274           
=========================================
  Files          5656     5656           
  Lines        497728   497793   +65     
  Branches      60360    60367    +7     
=========================================
+ Hits          80420    80442   +22     
- Misses       408357   408396   +39     
- Partials       8951     8955    +4     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.01% <40.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14200

[harikrishna-patnala]

code LGTM

[DaanHoogland]

clgtm, but includes a change in the storpool adaptor. @slavkap can you have a look?

[sureshanaparti]

clgtm, but includes a change in the storpool adaptor. @slavkap can you have a look?

@DaanHoogland I noticed an NPE in storpool adaptor, check the log in the issue #10981. cc @slavkap

[slavkap]

code LGTM
Thanks, @sureshanaparti, I have this fix in another PR #9478, but it will be better for this to get in an earlier release

[DaanHoogland]

clgtm

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

code lgtm

@sureshanaparti
If volume size is smaller than 1GB, ACS allocates 8GB on powerflex, right ?

[blueorangutan]

[SF] Trillian test result (tid-13799)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57765 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11211-t13799-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[sureshanaparti]

code lgtm

@sureshanaparti If volume size is smaller than 1GB, ACS allocates 8GB on powerflex, right ?

correct @weizhouapache

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14225

[vladimirpetrov]

LGTM, tested with Ubuntu 18, Debian 9 and macchinina templates.