-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[UI] Deploy VM: Restore preselection of the first available template #11207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. I haven't tested it
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11207 +/- ##
============================================
- Coverage 16.58% 16.58% -0.01%
Complexity 14038 14038
============================================
Files 5758 5758
Lines 511733 511735 +2
Branches 62216 62217 +1
============================================
Hits 84871 84871
- Misses 417389 417391 +2
Partials 9473 9473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UI build: ✔️ |
@nvazquez , do we know why the behaviour has changed and this patch is needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, not tested
I face this issue too
Hi @DaanHoogland I don't think it an issue but I raised it as an improvement to preserve the usual template selection from previous versions (I realized when tried to deploy a VM and it complained that no template was selected). It may probably got changed with the guest OS selection refactor on the deploy VM view |
Yes @nvazquez , it is an obvious annoyance, I was just wondering what we overlooked that caused this regression. |
I think it is caused by one of the recent changes with DeployVM.vue |
code looks good @nvazquez I am presuming this has nothing to do with this PR btw |
Thanks @DaanHoogland I'll double check this |
Hi @DaanHoogland the QA server is on 4.20.0 and doesn't have the needed tables/columns for the new Guest OS selection filtering on the Deploy VM view. Can you please test on a main branch env? |
of course 🤦 |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14218 |
same question remains @nvazquez : ![]() ![]() The template selected does not adhere to the os chosen, is this intended? |
@nvazquez I think it will be better if preselect the first template just after the API response. Somewhere in fetchImages or fetchAllTemplates in DeployVm/DeployVnf/CreateAutoscaleGroup, etc |
@DaanHoogland it looks intended as it hasn't changed - this PR just selects the first template from the list of templates. I've checked on the current main that changing the guest OS acts as filtering but does not select any template: Screen.Recording.2025-07-17.at.06.58.23.movMaybe this could be discussed separately? Anyways I don't think that is an issue, I think the guest OS is just a filter but should not change the selected template. cc @shwstppr @shwstppr thanks I will try exploring that solution |
Description
This PR restores the previous behavior on the Deploy VM view to select the first available template listed (has now changed on main branch)
Before the fix:

After the fix:

Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?