Skip to content

Conversation

@sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Jul 15, 2025

Description

This PR is meant to address issue reported in #10985 where volume usage doesn't have associated instanceId

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

❌ Patch coverage is 6.45161% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.18%. Comparing base (0c7d471) to head (fd73e76).
⚠️ Report is 46 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ava/com/cloud/upgrade/dao/Upgrade41930to41940.java 0.00% 22 Missing ⚠️
...java/com/cloud/usage/parser/VolumeUsageParser.java 0.00% 12 Missing ⚠️
...ma/src/main/java/com/cloud/event/UsageEventVO.java 0.00% 6 Missing ⚠️
...main/java/com/cloud/storage/dao/VolumeDaoImpl.java 40.00% 6 Missing ⚠️
...a/src/main/java/com/cloud/usage/UsageVolumeVO.java 0.00% 5 Missing ⚠️
...n/java/com/cloud/usage/dao/UsageVolumeDaoImpl.java 0.00% 5 Missing ⚠️
...rc/main/java/com/cloud/usage/UsageManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #11203   +/-   ##
=========================================
  Coverage     15.18%   15.18%           
- Complexity    11365    11370    +5     
=========================================
  Files          5416     5416           
  Lines        475890   475938   +48     
  Branches      58093    58096    +3     
=========================================
+ Hits          72255    72272   +17     
- Misses       395550   395577   +27     
- Partials       8085     8089    +4     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.91% <6.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudo87
Copy link
Collaborator Author

sudo87 commented Oct 14, 2025

Closing this pr, issue is resolved in this pr #11531

@sudo87 sudo87 closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant