Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Allow setting account and domain maximum amount of projects through the UI #10652

Merged

Conversation

bernardodemarco
Copy link
Collaborator

Description

Currently, it is not possible to change the limit of projects that a domain and account can have through the UI. Therefore, this PR proposes to add this field to the Configure Limits form of domains and accounts.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

image

How Has This Been Tested?

  • Verified that it was possible to modify the maximum amount of projects that an account can have through the UI
  • Verified that it was possible to modify the maximum amount of projects that a domain can have through the UI
  • Verified that the Max. projects field was not available on the projects Configure Limits form:
    image

@bernardodemarco bernardodemarco added this to the 4.19.3 milestone Apr 2, 2025
@bernardodemarco
Copy link
Collaborator Author

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (ee94ae5) to head (6dd6783).
Report is 2 commits behind head on 4.19.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10652   +/-   ##
=========================================
  Coverage     15.16%   15.17%           
- Complexity    11328    11330    +2     
=========================================
  Files          5415     5415           
  Lines        474824   474824           
  Branches      57912    57912           
=========================================
+ Hits          72014    72044   +30     
+ Misses       394757   394725   -32     
- Partials       8053     8055    +2     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10652 (QA-JID-593)

Copy link
Collaborator

@lucas-a-martins lucas-a-martins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in QA

@DaanHoogland DaanHoogland merged commit e08f88f into apache:4.19 Apr 8, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Apr 8, 2025
DaanHoogland pushed a commit that referenced this pull request Apr 9, 2025
* 4.20:
  xenserver: do not destroy halted hypervisor vm (#9175)
  define the limit of projects through the UI (#10652)
  fix projects metrics on dashboard (#10651)
  systemvm: Bump systemvm template version to debian 12.10 (#10628)
  Enhance VPC Network Tier form to auto-populate  Gateway, and Netmask (#10617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants