pre-commit upgrade codespell and fix spelling #10144

jbampton · 2024-12-28T09:09:32Z

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2024-12-28T09:17:04Z

Codecov Report

❌ Patch coverage is 14.63415% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.74%. Comparing base (83bccea) to head (2dd1710).
⚠️ Report is 207 commits behind head on main.

Files with missing lines	Patch %	Lines
...cloud/storage/resource/VmwareStorageProcessor.java	0.00%	10 Missing ⚠️
...om/cloud/deploy/DeploymentPlanningManagerImpl.java	0.00%	6 Missing ⚠️
...e/resource/StorageSubsystemCommandHandlerBase.java	0.00%	1 Missing and 1 partial ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	2 Missing ⚠️
.../xenserver/resource/XenServerStorageProcessor.java	0.00%	2 Missing ⚠️
...nserver/resource/Xenserver625StorageProcessor.java	50.00%	2 Missing ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	2 Missing ⚠️
.../CheckDataStoreStoragePolicyComplianceCommand.java	0.00%	1 Missing ⚠️
...torage/allocator/AbstractStoragePoolAllocator.java	0.00%	1 Missing ⚠️
...d/hypervisor/vmware/manager/VmwareManagerImpl.java	0.00%	1 Missing ⚠️
... and 6 more

Additional details and impacted files

@@             Coverage Diff              @@
##              main   #10144       +/-   ##
============================================
+ Coverage     3.89%   16.74%   +12.84%     
- Complexity       0    14063    +14063     
============================================
  Files          417     5724     +5307     
  Lines        33971   507787   +473816     
  Branches      6096    61734    +55638     
============================================
+ Hits          1324    85039    +83715     
- Misses       32489   413265   +380776     
- Partials       158     9483     +9325

Flag	Coverage Δ
uitests	`3.89% <ø> (-0.01%)`	⬇️
unittests	`17.66% <14.63%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland

I think we could refuse a lot of those spellos but lgtm like this as well (non native ;)

jbampton · 2024-12-28T11:39:36Z

@blueorangutan package

blueorangutan · 2024-12-28T11:40:07Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-28T11:55:10Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11930

DaanHoogland · 2024-12-29T20:33:28Z

@blueorangutan package

blueorangutan · 2024-12-29T20:34:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-29T21:49:15Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11939

.github/linters/codespell.txt

github-actions · 2025-01-08T14:37:52Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2025-04-26T15:30:53Z

@vishesh92 , lgty?

DaanHoogland · 2025-04-26T15:31:02Z

@blueorangutan package

blueorangutan · 2025-04-26T15:32:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-04-26T17:02:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13189

DaanHoogland · 2025-04-28T07:09:36Z

@blueorangutan test

blueorangutan · 2025-04-28T07:10:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-04-28T23:01:43Z

[SF] Trillian test result (tid-13172)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54043 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t13172-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_restore_vm_strict_tags_failure	`Failure`	58.55	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	`Failure`	58.74	test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure	`Failure`	5.71	test_vm_strict_host_tags.py

DaanHoogland · 2025-06-09T14:00:45Z

@vishesh92 are all your concerns met?

DaanHoogland · 2025-06-09T14:00:52Z

@blueorangutan package

blueorangutan · 2025-06-09T14:02:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-06-09T15:10:49Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13674

DaanHoogland · 2025-06-11T17:20:45Z

@blueorangutan test

blueorangutan · 2025-06-11T17:22:05Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

vishesh92 · 2025-06-12T06:58:26Z

@DaanHoogland @jbampton Since we are changing names of the Command classes, the requests might fail on agents until they are upgraded. IMO this requires some upgrade testing to ensure no issues occur during an upgrade. For a fresh install, there should be no issues.

blueorangutan · 2025-06-12T11:09:52Z

[SF] Trillian test result (tid-13501)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60771 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10144-t13501-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

github-actions · 2025-06-16T07:14:26Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

vishesh92

code lgtm

sureshanaparti · 2025-07-28T09:07:27Z

.github/linters/codespell.txt

 algoritm
 allo
-alloacate
 allocted


Suggested change

allocted

it has one occurance, we need to edit VpcManagerImpl line 2837 than as well. another PR?

github-actions · 2025-07-29T13:37:28Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

boring-cyborg bot added component:api component:integration-test component:kvm component:simulator component:storage component:vmware component:XenServer Python Warning... Python code Ahead! labels Dec 28, 2024

jbampton closed this Dec 28, 2024

jbampton reopened this Dec 28, 2024

DaanHoogland approved these changes Dec 28, 2024

View reviewed changes

vishesh92 reviewed Dec 31, 2024

View reviewed changes

.github/linters/codespell.txt Outdated Show resolved Hide resolved

vishesh92 reviewed Dec 31, 2024

View reviewed changes

.github/linters/codespell.txt Outdated Show resolved Hide resolved

vishesh92 reviewed Dec 31, 2024

View reviewed changes

.github/linters/codespell.txt Outdated Show resolved Hide resolved

github-actions bot added the status:has-conflicts label Jan 8, 2025

jbampton mentioned this pull request Mar 29, 2025

scripts(shell): counts of misspelled words in the codebase #10639

Open

pre-commit upgrade codespell and fix spelling

ef08967

jbampton force-pushed the pre-commit-update-codespell branch from b833c07 to ef08967 Compare April 25, 2025 16:27

boring-cyborg bot added component:agent component:hyperv component:networking labels Apr 25, 2025

github-actions bot removed the status:has-conflicts label Apr 25, 2025

Fix up

2dd1020

DaanHoogland added component:upgrade status:needs-testing labels Jun 12, 2025

github-actions bot added the status:has-conflicts label Jun 16, 2025

jbampton added 2 commits July 24, 2025 20:17

Merge

9074a27

Recreate codespell ignored words list

53784f2

jbampton force-pushed the pre-commit-update-codespell branch from 0c16198 to 53784f2 Compare July 24, 2025 10:44

github-actions bot removed the status:has-conflicts label Jul 24, 2025

Fix up merge

2dd1710

vishesh92 approved these changes Jul 28, 2025

View reviewed changes

sureshanaparti reviewed Jul 28, 2025

View reviewed changes

github-actions bot added the status:has-conflicts label Jul 29, 2025

pre-commit upgrade codespell and fix spelling #10144

Are you sure you want to change the base?

pre-commit upgrade codespell and fix spelling #10144

Uh oh!

Conversation

jbampton commented Dec 28, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Dec 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

jbampton commented Dec 28, 2024

Uh oh!

blueorangutan commented Dec 28, 2024

Uh oh!

blueorangutan commented Dec 28, 2024

Uh oh!

DaanHoogland commented Dec 29, 2024

Uh oh!

blueorangutan commented Dec 29, 2024

Uh oh!

blueorangutan commented Dec 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 8, 2025

Uh oh!

DaanHoogland commented Apr 26, 2025

Uh oh!

DaanHoogland commented Apr 26, 2025

Uh oh!

blueorangutan commented Apr 26, 2025

Uh oh!

blueorangutan commented Apr 26, 2025

Uh oh!

DaanHoogland commented Apr 28, 2025

Uh oh!

blueorangutan commented Apr 28, 2025

Uh oh!

blueorangutan commented Apr 28, 2025

Uh oh!

DaanHoogland commented Jun 9, 2025

Uh oh!

DaanHoogland commented Jun 9, 2025

Uh oh!

blueorangutan commented Jun 9, 2025

Uh oh!

blueorangutan commented Jun 9, 2025

Uh oh!

DaanHoogland commented Jun 11, 2025

Uh oh!

blueorangutan commented Jun 11, 2025

Uh oh!

vishesh92 commented Jun 12, 2025

Uh oh!

blueorangutan commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 16, 2025

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 28, 2024 •

edited

Loading