fix: convert domain_id list before setting it on network offering create - #343
Open
nagaboinaramgopal wants to merge 1 commit into
Open
Conversation
domain_id is a schema.TypeList, so the SDK returns []interface{}, but create asserted v.([]string) and panicked with an interface conversion error when domain_id is set. Build a []string, which is what the create SetDomainid takes.
nagaboinaramgopal
force-pushed
the
fix/network-offering-domainid-panic
branch
from
September 7, 2026 19:07
18b3d0f to
6ca6071
Compare
nagaboinaramgopal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
domain_idoncloudstack_network_offeringis aschema.TypeList, so the SDK returns[]interface{}, but create assertedv.([]string)and panicked withinterface conversion: interface {} is []interface {}, not []stringwhendomain_idis set. Fixed by building a[]string, which is what the createSetDomainidtakes.Testing
Added a unit test
TestNetworkOfferingDomainIdDoesNotPanicthat runs the create function withdomain_idset against an unreachable endpoint. It needs no live CloudStack:It panics against the current code and passes with the fix.