Increase timeout for acceptance tests - #341
Merged
Merged
Conversation
Contributor
Author
|
Unsure whether these actually get stuck on waiting for something or just take too long, this is moreso just a hail mary to see if it fixes the timeouts. |
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Increases the acceptance test timeout to reduce flaky CI failures caused by slow GitHub Actions runners.
Changes:
- Bump
testaccGo test timeout from 30 minutes to 45 minutes.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current GitHub actions runners cannot keep up with the 30 minute timeout. It's a hit or miss whether it completes within time or not. Upping this to 45 minutes (or something in between if there are objections) should make results a bit more predictive.