-
Notifications
You must be signed in to change notification settings - Fork 48
Add ability to work with projects #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
there are several issues with this PR I created a PR for vpc in project: #209 |
@@ -37,6 +37,11 @@ func dataSourceCloudstackIPAddress() *schema.Resource { | |||
Schema: map[string]*schema.Schema{ | |||
"filter": dataSourceFiltersSchema(), | |||
|
|||
"projectid": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a field project
. Can't we use that instead?
@@ -37,6 +37,11 @@ func dataSourceCloudstackVPC() *schema.Resource { | |||
Schema: map[string]*schema.Schema{ | |||
"filter": dataSourceFiltersSchema(), | |||
|
|||
"projectid": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a field project. Can't we use that instead?
@JSpon Could you please resolve the review comments |
Several data sources and resources have project support. This is to add it to more data sources and resources.