Skip to content

Conversation

JSpon
Copy link

@JSpon JSpon commented Nov 6, 2024

Several data sources and resources have project support. This is to add it to more data sources and resources.

@CodeBleu CodeBleu added the enhancement New feature or request label Dec 18, 2024
@CodeBleu CodeBleu added this to the v0.6.0 milestone Dec 18, 2024
@CodeBleu
Copy link
Collaborator

@JSpon Thanks for your contribution. Can you please add tests for this? It's also good to follow this once you've added your tests as this can help catch things before the github workflow runs it.

@weizhouapache
Copy link
Member

there are several issues with this PR

I created a PR for vpc in project: #209

@@ -37,6 +37,11 @@ func dataSourceCloudstackIPAddress() *schema.Resource {
Schema: map[string]*schema.Schema{
"filter": dataSourceFiltersSchema(),

"projectid": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a field project. Can't we use that instead?

@@ -37,6 +37,11 @@ func dataSourceCloudstackVPC() *schema.Resource {
Schema: map[string]*schema.Schema{
"filter": dataSourceFiltersSchema(),

"projectid": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a field project. Can't we use that instead?

@kiranchavala
Copy link
Collaborator

@JSpon Could you please resolve the review comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants