Modify State Changing Requests to Utilize POST Request #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohityadavcloud
requested review from
vishesh92,
Pearl1594,
sureshanaparti and
weizhouapache
cloudstack/AccountService.go
Outdated
| @@ -1104,7 +1104,7 @@ func (s *AccountService) NewIsAccountAllowedToCreateOfferingsWithTagsParams() *I | |||
|
|
|||
| // Return true if the specified account is allowed to create offerings with tags. | |||
| func (s *AccountService) IsAccountAllowedToCreateOfferingsWithTags(p *IsAccountAllowedToCreateOfferingsWithTagsParams) (*IsAccountAllowedToCreateOfferingsWithTagsResponse, error) { | |||
| resp, err := s.cs.newRequest("isAccountAllowedToCreateOfferingsWithTags", p.toURLValues()) | |||
| resp, err := s.cs.newPostRequest("isAccountAllowedToCreateOfferingsWithTags", p.toURLValues()) | |||
There was a problem hiding this comment.
Suggested change
| resp, err := s.cs.newPostRequest("isAccountAllowedToCreateOfferingsWithTags", p.toURLValues()) | |
| resp, err := s.cs.newRequest("isAccountAllowedToCreateOfferingsWithTags", p.toURLValues()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently State Changing Request utilize GET request but this is a potential security vulnerability since attackers may be able to intercept and extract the query parameters of GET requests. Utilizing POST requests will help mitigate this security vulnerability since the parameters of the POST body will be encrypted in transport.